fix(select): add select option background-color #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
|
This PR introduces visual changes: 3d1f947 |
|
This PR introduces visual changes: a87a099 |
|
There are no visual regressions in this change. The above regression comments are due to a flaky test for the button loading state (I think). I'm investigating that in a separate PR. |
dtsanevmw
approved these changes
Dec 7, 2023
williamernest
added a commit
that referenced
this pull request
Dec 7, 2023
Update the playwright config to allow two retries for failed tests. When a test fails, that individual test will be retried twice, and if it fails every time, the last screenshot will be retained for different comparisons. This should help overcome the flaky button issues seen on this PR and #1088 . --------- Co-authored-by: GitHub <noreply@github.com>
williamernest
added a commit
that referenced
this pull request
Dec 7, 2023
Update the playwright config to allow two retries for failed tests. When a test fails, that individual test will be retried twice, and if it fails every time, the last screenshot will be retained for different comparisons. This should help overcome the flaky button issues seen on this PR and #1088 . --------- Co-authored-by: GitHub <noreply@github.com>
williamernest
force-pushed
the
wernest/fix_select_option_background_color
branch
from
3025b34 to
bb1294c
Compare
kevinbuhmann
approved these changes
Dec 7, 2023
williamernest
added a commit
that referenced
this pull request
Dec 7, 2023
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: The background of the select options dropdown is white when in dark mode (on Windows), making the text difficult to read. Issue Number: CDE-1492 This fix adds the background-color of the options to match the textarea in the clr theme, and uses the cds-alias-object-interaction-background token in the cds theme. - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> 
williamernest
added a commit
that referenced
this pull request
Dec 7, 2023
… (#1096) Update the playwright config to allow two retries for failed tests. When a test fails, that individual test will be retried twice, and if it fails every time, the last screenshot will be retained for different comparisons. This should help overcome the flaky button issues seen on this PR and #1088 . Port of #1089 Co-authored-by: GitHub <noreply@github.com>
dtsanevmw
pushed a commit
that referenced
this pull request
Dec 9, 2023
… (#1096) Update the playwright config to allow two retries for failed tests. When a test fails, that individual test will be retried twice, and if it fails every time, the last screenshot will be retained for different comparisons. This should help overcome the flaky button issues seen on this PR and #1088 . Port of #1089 Co-authored-by: GitHub <noreply@github.com>
|
🎉 This PR is included in version 16.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
williamernest
added a commit
that referenced
this pull request
Dec 13, 2023
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: The background of the select options dropdown is white when in dark mode (on Windows), making the text difficult to read. Issue Number: CDE-1492 This fix adds the background-color of the options to match the textarea in the clr theme, and uses the cds-alias-object-interaction-background token in the cds theme. - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> 
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The background of the select options dropdown is white when in dark mode (on Windows), making the text difficult to read.
Issue Number: CDE-1492
What is the new behavior?
This fix adds the background-color of the options to match the textarea in the clr theme, and uses the cds-alias-object-interaction-background token in the cds theme.
Does this PR introduce a breaking change?
Other information